Firestore clone support #9262
Open
Firestore clone support #9262
+264
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwhogg
force-pushed
the
rh-firestore-clone
branch
2 times, most recently
from
610c8ed to
224e9f8
Compare
rwhogg
force-pushed
the
rh-firestore-clone
branch
from
224e9f8 to
9bb892b
Compare
joehan
reviewed
Oct 7, 2025
| const helpCommandText = "See firebase firestore:databases:clone --help for more info."; | ||
|
|
||
| if (options.database) { | ||
| throw new FirebaseError(`Please do not use --database for this command. ${helpCommandText}`); |
There was a problem hiding this comment.
Suggested change
| throw new FirebaseError(`Please do not use --database for this command. ${helpCommandText}`); | |
| throw new FirebaseError(`--database is not a supported flag for 'firestoree:databases:clone'. ${helpCommandText}`); |
| const targetDatabaseId = targetDatabaseName.databaseId; | ||
| const sourceProject = parseDatabaseName(sourceDatabase).projectId; | ||
| if (parentProject !== sourceProject) { | ||
| throw new FirebaseError(`Source and target projects must match.`); |
There was a problem hiding this comment.
Suggested change
| throw new FirebaseError(`Source and target projects must match.`); | |
| throw new FirebaseError(`Cloning across projects is not supported.`); |
| "block any incoming third-party traffic.", | ||
| ); | ||
| logger.info(); | ||
| logger.info(`You can monitor the progress of this clone by executing this command:`); |
There was a problem hiding this comment.
How long is this operation usually? Would it make more sense to just poll on the operation here until it is done?
| | UseSourceEncryption | ||
| | UseGoogleDefaultEncryption; | ||
|
|
||
| export interface PitrSnapshot { |
There was a problem hiding this comment.
Suggested change
| export interface PitrSnapshot { | |
| export interface PITRSnapshot { |
| payload, | ||
| options, | ||
| ); | ||
| const lro = res.body; |
There was a problem hiding this comment.
Related to above - we should maybe poll on this using the existing PollOperation utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Firestore Database Clone
Scenarios Tested
Sample Commands
firebase firestore:databases:clone projects/myproject/databases/original-db projects/myproject/databases/clone(chooses most recent available snapshot)firebase firestore:databases:clone projects/myproject/databases/original-db projects/myproject/databases/clone2 --snapshot-time 2025-10-06T10:00:00Z(uses selected snapshot time)firebase firestore:databases:clone projects/myproject/databases/original-db projects/myproject/databases/db-with-same-encryption --snapshot-time 2025-10-06T10:00:00Z --encryption-type USE_SOURCE_ENCRYPTIONfirebase firestore:databases:clone projects/myproject/databases/original-db projects/myproject/databases/db-with-kms-encryption --snapshot-time 2025-10-06T10:00:00Z --encryption-type CUSTOMER_MANAGED_ENCRYPTION --kms-key-name projects/myproject/locations/us-central1/keyRings/testkeyring/cryptoKeys/k1firebase firestore:databases:clone projects/myproject/databases/original-db projects/myproject/databases/db-with-google-managed-encryption --snapshot-time 2025-10-06T10:00:00Z --encryption-type GOOGLE_DEFAULT_ENCRYPTION